Offer the handle control to any verified account - #7
Merged
Conversation
Custom handles are free now, so the Change-handle button no longer keys off the tier. It is shown to everyone and disabled — with the reason — for an unverified email, since hiding it is what made the tier gate unreadable. The claim modal maps the server's new 403 to "verify your email first" in place of the dead 402 branch. email_verified is taken from /v1/auth/me rather than the JWT claim: the token predates a verification the user may have completed since it was issued, and this value now decides whether the control is offered. Rendered in a browser at both states before committing — the row's first visual check.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom handles are becoming free, so the portal's Change-handle button stops keying off the tier.
email_verifiednow comes from/v1/auth/merather than the JWT claim: the token predates a verification the user may have completed since it was issued, and that value now decides whether the control is offered.Verification
This repo has no test suite and no working lint, so it was checked by rendering it.
next build(including its TypeScript pass) is clean, and the Handle row was driven in a real browser in both states — verified (button enabled) and unverified (button disabled, reason shown). That is the first time this row has been rendered anywhere.Deploy order
This ships first, ahead of the server. It is the only piece that is safe before the server change and unsafe after it. Client last, as always.
Related: VoltiusApp/server#6 and VoltiusApp/voltius#126.